Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings from moved utils functions #1719

Closed
serbinsh opened this issue Oct 9, 2017 · 4 comments
Closed

Deprecation warnings from moved utils functions #1719

serbinsh opened this issue Oct 9, 2017 · 4 comments

Comments

@serbinsh
Copy link
Member

serbinsh commented Oct 9, 2017

Found a few tools moved from utils that still need to be cleaned up

2017-10-09 15:11:37 DEBUG  [PEcAn.logger::logger.debug] : 
   Waiting for the following jobs: 105128 105129 105130 105131 105132 
Warning: '$.SafeList' is deprecated.
Use 'PEcAn.settings::$.SafeList' instead.
See help("Deprecated")
Warning: '$.SafeList' is deprecated.
Use 'PEcAn.settings::$.SafeList' instead.
See help("Deprecated")
Warning: '$.SafeList' is deprecated.
Use 'PEcAn.settings::$.SafeList' instead.

and

2017-10-09 15:11:17 DEBUG  [PEcAn.logger::logger.debug] : 
   updated met path: 
   /data/Model_Output/pecan.output/dbfiles/CRUNCEP_SIPNET_site_2-5/CRUNCEP.1990-01-01.2010-12-31.clim 
Warning: 'listToXml.default' is deprecated.
Use 'PEcAn.settings::listToXml.default' instead.
See help("Deprecated")
Warning: 'listToXml' is deprecated.
Use 'PEcAn.settings::listToXml' instead.
See help("Deprecated")
Warning: 'listToXml.default' is deprecated.
Use 'PEcAn.settings::listToXml.default' instead.

Description

Move to settings

@infotroph
Copy link
Member

infotroph commented Oct 11, 2017

It appears that these deprecation warnings happen inside functions from PEcAn.utils, where the deprecated local copies of the method are always higher in the search path than the now-official PEcAn.settings copies. I see three possible resolutions:

  1. Note that the deprecated functions still work, do nothing, and repeatedly assure users that these warnings are nothing to worry about.
  2. Delete the copies in PEcAn.utils now, with no deprecation period.
  3. Implement Move workflow functions from utils to own package #1722 in a way that ensures all calls to SafeList, listToXml, etc occur in an environment where the PEcAn.settings namespace is found before the PEcAn.utils namespace.

@infotroph infotroph changed the title Cleaning up remaining utils issues Deprecation warnings from moved utils functions Oct 12, 2017
@infotroph
Copy link
Member

Tentative plan is to remove the deprecated functions in v1.5.2.

@bcow
Copy link
Contributor

bcow commented Oct 26, 2017

One argument for resolving this sooner as opposed to later is that it makes the build output so long that it can't be displayed in 10000 lines and thus you can't get to the end the online log for a failed Travis build (I downloaded the raw log and it was over 14000 lines)

@serbinsh
Copy link
Member Author

serbinsh commented Nov 6, 2017

Yeah that is a good reason

mdietze added a commit that referenced this issue Nov 21, 2017
remove deprecated functions in PEcAn.utils. Closes #1719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants