Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run.biocro return values do not vary #1738

Closed
infotroph opened this issue Oct 27, 2017 · 0 comments · Fixed by #1739
Closed

run.biocro return values do not vary #1738

infotroph opened this issue Oct 27, 2017 · 0 comments · Fixed by #1739

Comments

@infotroph
Copy link
Member

> out <- PEcAn.BIOCRO::run.biocro(lat, lon,
+                  metpath = metpath,
+                  soil.nc = soil.nc, 
+                  config = config)
> head(out$daily)
       lat      lon year doy     Stem     Leaf     Root
1: 40.0061 -88.2919 2004   1 45.79881 5.711558 3.674523
2: 40.0061 -88.2919 2004   2 45.79881 5.711558 3.674523
3: 40.0061 -88.2919 2004   3 45.79881 5.711558 3.674523
4: 40.0061 -88.2919 2004   4 45.79881 5.711558 3.674523
5: 40.0061 -88.2919 2004   5 45.79881 5.711558 3.674523
6: 40.0061 -88.2919 2004   6 45.79881 5.711558 3.674523
# <snip>
> length(unique(out$daily$Leaf))
[1] 1

This is a regression caused by the changes in #1620 -- the summary code is now taking max/sum across entire run rather than within days.

I have a fix in progress.

Description

Context

Possible Implementation

@infotroph infotroph self-assigned this Oct 27, 2017
mdietze added a commit that referenced this issue Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant