Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ED2IN.git is out of date #2143

Closed
ashiklom opened this issue Oct 10, 2018 · 5 comments · Fixed by #2598
Closed

ED2IN.git is out of date #2143

ashiklom opened this issue Oct 10, 2018 · 5 comments · Fixed by #2598

Comments

@ashiklom
Copy link
Member

Describe the bug
New versions of ED need the following additional ED2IN tags, which are missing from the current version of ED:

IOOUTPUT, it must be 0 (none) or 3 (HDF5)
PLANT_HYDRO_SCHEME, it must be between -2 and 2
ISTOMATA_SCHEME, it must be between 0 and 1
ISTRUCT_GROWTH_SCHEME, it must be between 0 and 1
TRAIT_PLASTICITY_SCHEME, it must be between 0 and 2

To Reproduce
Build a fresh ED2 Docker container (which pulls from Git) and try to do a run via the PEcAn web interface.

Expected behavior
Model should run.

Machine (please complete the following information):

  • Docker
@ashiklom
Copy link
Member Author

Working on this in https://github.com/ashiklom/pecan/tree/ed2in-update

@robkooper
Copy link
Member

this is a good example of why we should use a specific commit of ED :) This was done about 2 months ago (https://github.com/EDmodel/ED2/pull/254/files)

@serbinsh
Copy link
Member

Again this is related to #2081 and why we need to careful what ED2IN we call "git" etc. But again this is a larger issue

@github-actions
Copy link

This issue is stale because it has been open 365 days with no activity.

@robkooper
Copy link
Member

we should make sure we have one for 2.2.0, and close this issue after that. If people want to use the git version they can use the fix by @ashiklom

@robkooper robkooper added this to the 1.8.0 milestone Apr 14, 2020
@dlebauer dlebauer mentioned this issue May 6, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants