Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add model_info.json to models/template #2567

Closed
infotroph opened this issue Apr 13, 2020 · 1 comment
Closed

add model_info.json to models/template #2567

infotroph opened this issue Apr 13, 2020 · 1 comment
Milestone

Comments

@infotroph
Copy link
Member

  • We now expect all models to have a model_info.json going forward, correct? If so, we should give an example in models/template
  • If it's standard for model_info.json to live in the package root (rather than inst/ like register.*.xml did), will also need to list it in .Rbuildignore to prevent "non-standard files /directories found at top level" note at check time

(Moved from #2566 (comment))

@robkooper
Copy link
Member

the code that connects and wait for model runs (as well as advertises the heartbeat) is written in python (there are no RabbitMQ bindings). We can put the model_info.json in inst as well and just need to copy it to the right location when we build the docker file.

@robkooper robkooper added this to the 1.8.0 milestone Apr 14, 2020
robkooper added a commit that referenced this issue May 5, 2020
add dockerfile, model_info.json to template (fixes #2567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants