Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for sql injection paths; switch to using prepared sql statements (dplyr?) #395

Open
robkooper opened this issue Mar 23, 2015 · 4 comments

Comments

@robkooper
Copy link
Member

Pecan code base has lots of places where an sql injection can happen. We should switch as soon as possible to using prepared statements. We should look at the package dplyr for the database code (http://cran.rstudio.com/web/packages/dplyr/vignettes/databases.html). This package has two functions that might be hand escape and sql that will help create the queries.

dplyr has some other nice features in that you don't write sql statements but use functions to create select statements etc.

@robkooper robkooper self-assigned this Mar 23, 2015
@robkooper robkooper added this to the 1.4.3 Benchmark calculations milestone Mar 23, 2015
@dlebauer dlebauer changed the title check for sql injection paths check for sql injection paths; switch to using prepared sql statements (dplyr?) Apr 24, 2015
@tonygardella tonygardella modified the milestones: 1.4.5: Benchmark workflow, 1.4.4 Sep 30, 2015
@mdietze
Copy link
Member

mdietze commented Jan 25, 2016

@robkooper status?

@robkooper robkooper removed this from the 1.4.5: CRUNCEP, Preles milestone Jan 28, 2016
@robkooper
Copy link
Member Author

removed milestone since this is a bigger issue that will need to be resolved slowly over time.

@ashiklom
Copy link
Member

@infotroph and I will probably try to tag-team this, as it's relevant for his Biocro work and my work on importing TRY.

@github-actions
Copy link

This issue is stale because it has been open 365 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants