Fix for the ensemble weights in refactored/single site SDA #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
para2x
changed the title
mdietze
reviewed
Sep 4, 2019
| PEcAn.logger::logger.warn("ensemble_weights.Rdata cannot be found. Make sure you generate samples by running the get.ensemble.weights function before running SDA if you want the ensembles to be weighted.") | ||
| #create null list | ||
| for(tt in 1:length(obs.times)){ | ||
| weight_list[[tt]] <- rep(1,nens) #no weights |
There was a problem hiding this comment.
just checking, but doesn't this result in weight_list not being defined at all if settings$run$inputs$ensembleweights$path is NULL? That seems dangerous. To me it seems like we should run this for loop either when the file doesn't exist or when the path is null.
Also, what's the point of defining settings$run$inputs$ensembleweights$path if that path isn't the one being used to open the file? load(file.path(settings$outdir, "ensemble_weights.Rdata"))
There was a problem hiding this comment.
My mistake this would have been fine with the original piece, The bug has to do with the change in the restart functionality which I'm trying to resolve.
…into sda_ensemble_weight
mdietze
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a short discussion with @kzarada and @araiho, I realized I pulled something from @araiho PR into the mainline which resulted a small bug for @kzarada project. After another discussion with @araiho here is a small fix for that bug.
Description
Motivation and Context
Review Time Estimate
Types of changes
Checklist: