Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEcAn API: Workflow status, download input/output files, JSON workflow submission #2674
PEcAn API: Workflow status, download input/output files, JSON workflow submission #2674
Changes from all commits
265e4e4
e2c34b7
466de00
9d9b9c9
4d59ab2
b255c9e
073dc79
8ceb9be
ff63d16
304dd3a
d8e3e46
d54f257
64f3e07
32e1fe8
05a14f3
6d86713
321ee6a
a8ae247
0d4f1ea
1f78930
6480af8
0a45e87
0c774ba
134b3af
11290f6
942e1ae
ac38526
c97d4bc
3ddfcf6
80491b2
eb6e2c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to return different error messages for the file not existing vs nrow(input)==0? Having these two cases return the same error doesn't tell the user what happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm...that's a bit inconvenient I guess because the content-type is specified to be
application/octet-stream
as a decorator over the function, and changing that here may not be the easiest thing to do as of now. I think we can keep this on a hold for now & meanwhile I will see if something could be done.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Not the end of the world. Just didn't know if there was a way to send back a message in addition to the raw status code. Definitely not worth holding up this PR for.