Patch for get.trait.data.pft.R #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdietze
requested changes
Feb 8, 2021
| na.strings = c("", "NA") | ||
| ) | ||
| diff_membership <- symmetric_setdiff( | ||
| if (pfttype == "plant") { |
There was a problem hiding this comment.
There seems to be a lot more duplicate code here than necessary. Could we just have the if be used to define the colClasses variable, and then use that variable in the existing_membership load?
There was a problem hiding this comment.
Okay, fixed to be much more compact. Thanks!
mdietze
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an if/else to the existing_membership check, which pulls in either species.csv or cultivars.csv for comparison. Crucially, the column classes differ between the two types.
Description
'species.csv' has 4 columns, the first of which has to be numeric. 'cultivars.csv' has 6 columns, the first 2 of which have to be numeric.
Motivation and Context
When the meta-analysis update is set to FALSE in the pecan.xml file, pfts with cultivars can now have meta-analysis results ported over from a previous run, reducing the need to rerun the meta-analysis each time.
Review Time Estimate
Types of changes
Checklist: