Last few tweaks for the logger package before it moves to CRAN #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdietze
approved these changes
Jul 22, 2021
infotroph
requested changes
Jul 22, 2021
Co-authored-by: Chris Black <chris@ckblack.org>
|
@moki1202 I believe the last step needed here is to bump the version (to 1.8.0, in both DESCRIPTION and NEWS.md) and date. Then we can build, final-test, and submit! |
infotroph
reviewed
Jul 26, 2021
Co-authored-by: Chris Black <chris@ckblack.org>
infotroph
approved these changes
Jul 27, 2021
robkooper
approved these changes
Jul 27, 2021
|
@moki1202 if you feel it is ready, mark it ready for review so it can be merged. And we can push it to cran. |
|
I believe we are ready to role!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.