Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert last uses of deprecated PEcAn.utils::logger* to PEcAn.logger::loger* #2831

Merged
merged 1 commit into from
Jul 31, 2021

Conversation

infotroph
Copy link
Member

Description

The logger functions in PEcAn.utils have been deprecated for several years and will be removed entirely in #2830.

These are the only remaining uses of them I could find in the codebase, but if you're reading this please check all your local scripts and update them now!

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mdietze mdietze merged commit 03bad09 into PecanProject:develop Jul 31, 2021
@infotroph infotroph deleted the logger-call-from-logger branch November 9, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants