Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issues #2955 and #2959 #3010

Merged
merged 9 commits into from
Oct 29, 2022
Merged

Conversation

hangyakuzero
Copy link
Contributor

@hangyakuzero hangyakuzero commented Aug 7, 2022

Description

Recently @robkooper changed the way the docker install works so that pecan is reached from http://pecan.localhost/ instead of http://localhost:8000/. I've made the changes in the documentation in #2935, but there are still instances of "localhost:8000" in tests, shell scripts,etc. I have made the changes accordingly.
Also I have changed the regex pattern as required.

this fixes issue #2955 and #2959

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hangyakuzero hangyakuzero changed the title changed to http://pecan.localhost/ from http://localhost:8000/ in a few files fixes issues #2955 and #2955 Aug 7, 2022
@hangyakuzero hangyakuzero changed the title fixes issues #2955 and #2955 fixes issues #2955 and #2959 Aug 7, 2022
@Aariq Aariq linked an issue Oct 3, 2022 that may be closed by this pull request
@infotroph
Copy link
Member

This still won't catch jobids without a literal space before them (e.g. my old frenemy "ondemand52.aci.ics.psu.edu.568420642 submitted"), but my sense is that in practice every default involving qsub should be thought of less as a value that will work for most people and more as an example of how to specify your own value when the default inevitably fails on your system. Therefore I support merging this as it is.

@mdietze mdietze merged commit 0e70422 into PecanProject:develop Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update code to reflect new docker endpoint
5 participants