Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated write.configs.ed to throw an error if revision not specified #3156

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

meetagrawal09
Copy link
Collaborator

Description

This PR fixes #3142

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@meetagrawal09
Copy link
Collaborator Author

@mdietze, @Aariq should I turn to using logger.error in-place of logger.severe for the fix ?

@mdietze
Copy link
Member

mdietze commented Apr 1, 2023

I think either error or severe is fine. We tend to lean towards error over severe in cases where there are multiple ensemble members and/or locations and only a subset might be failing (i.e. we don't want to kill other ensemble members over an error in just one).

If this fix eliminates the dependency on PEcAn.DB then the DESCRIPTION and make should also be updated

@mdietze mdietze added this pull request to the merge queue Apr 1, 2023
Merged via the queue into PecanProject:develop with commit 34ec9a2 Apr 1, 2023
@meetagrawal09 meetagrawal09 deleted the dev-fix-#3142 branch April 2, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write.configs.ed should error if revision not specified
2 participants