Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post quantum certificates #91

Merged
merged 9 commits into from Mar 13, 2023
Merged

Post quantum certificates #91

merged 9 commits into from Mar 13, 2023

Conversation

microshine
Copy link
Contributor

@microshine microshine commented Mar 11, 2023

This pull request adds two new packages to the project: @peculiar/asn1-rfc5958 and @peculiar/asn1-x509-pq.

@peculiar/asn1-rfc5958 provides ASN.1 schema definitions for the asymmetric key packages format specified in RFC5958. This format is used to encapsulate private and public keys, along with additional parameters and metadata, for a variety of asymmetric key algorithms. The package is designed to be lightweight and easy to use, while still providing all of the necessary functionality for working with the format.

@peculiar/asn1-x509-pq provides ASN.1 schema definitions for composite public and private keys and composite signatures used in Internet Public Key Infrastructure (PKI), as specified in the following IETF drafts:

@coveralls
Copy link

coveralls commented Mar 11, 2023

Pull Request Test Coverage Report for Build 4407090580

  • 46 of 48 (95.83%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 86.632%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/asym-key/src/index.ts 19 21 90.48%
Totals Coverage Status
Change from base Build 3418485408: 0.1%
Covered Lines: 2527
Relevant Lines: 2786

💛 - Coveralls

@microshine microshine marked this pull request as ready for review March 13, 2023 16:13
@microshine microshine merged commit 71bc500 into master Mar 13, 2023
@microshine microshine deleted the post-quantum branch March 13, 2023 16:15
@ounsworth
Copy link

Great to see our drafts getting actually used!
Any trouble in implementing it, or suggestions for the drafts?

@johngray-dev
Copy link

Great to see this being added! We just posted an updated to the composite drafts yesterday which adds 'explicit composite support'. Essentially using Object ID's to identify pairs of algorithms in composite form which are most likely to be used together. You are welcome to post artifacts to our artifact repository at https://github.com/IETF-Hackathon/pqc-certificates for interoperability testing. Let me know if you want to be added to the github repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants