Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Don't pollute global scope with atob and btoa #114

Merged
merged 1 commit into from Jan 18, 2018
Merged

Don't pollute global scope with atob and btoa #114

merged 1 commit into from Jan 18, 2018

Conversation

LiraNuna
Copy link
Contributor

These functions aren't use, and pollute the global scope with unrelated variables.
If this is used as dependency somehow, I highly suggest using a separate package to fill the gap.

Fixes #99

@microshine
Copy link
Contributor

@LiraNuna Thank you for PR
You are right. It's odd code

webcrypto-core has own global btoa and atob functions
https://github.com/PeculiarVentures/webcrypto-core/blob/master/src/base64url.ts#L2-L6

btoa and atob are needed for Base64Url coder https://github.com/PeculiarVentures/webcrypto-core/blob/master/src/base64url.ts#L12

@microshine microshine merged commit 0257342 into PeculiarVentures:master Jan 18, 2018
@LiraNuna LiraNuna deleted the remove_atob_btoa branch January 18, 2018 18:47
@coveralls
Copy link

coveralls commented Jan 20, 2018

Coverage Status

Coverage decreased (-0.03%) to 90.333% when pulling aca4686 on LiraNuna:remove_atob_btoa into 19d482e on PeculiarVentures:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants