Add type check step to build workflow

Pedro-Bronsveld · Apr 18, 2023 · 2eb104b · 2eb104b
1 parent 8e2c40d
commit 2eb104b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -16,6 +16,8 @@ jobs:
         uses: actions/checkout@v3
       - name: Install packages
         run: npm ci
+      - name: Run type checking
+        run: npm run typecheck
       - name: Build and package extension
         run: npm run package -- $(cut -c 2- <<< $GITHUB_REF_NAME)
       - name: Upload vsix file to GitHub release 

diff --git a/src/anki-connect/anki-connect.ts b/src/anki-connect/anki-connect.ts
@@ -36,7 +36,7 @@ export default class AnkiConnect {
 
         const permissionResult = await this.requestPermission();
 
-        if (permissionResult.requireApikey === false)
+        if (permissionResult.permission === "granted" && permissionResult.requireApiKey === false)
             // Don't return api key if not required for requests.
             return undefined;