Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing hook dependency #125

Merged
merged 1 commit into from
Feb 13, 2021
Merged

fix: add missing hook dependency #125

merged 1 commit into from
Feb 13, 2021

Conversation

andreialecu
Copy link
Collaborator

scrollTo was not in the dependency array, so updates to the contentInset value would not properly propagate to it, resulting in wrong scroll sync positions if the headerHeight property was not provided.

@andreialecu andreialecu merged commit d741e74 into main Feb 13, 2021
@andreialecu andreialecu deleted the aa/fix-hookdep branch February 13, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant