Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header gets stuck if a tab doesnt have enough content #8

Closed
jnsvu opened this issue Nov 29, 2020 · 2 comments
Closed

Header gets stuck if a tab doesnt have enough content #8

jnsvu opened this issue Nov 29, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@jnsvu
Copy link

jnsvu commented Nov 29, 2020

First of all, thanks for creating this awesome wrapper!

As you can see, when I scroll down the A tab and switch to B, the header gets stuck and there is empty space between the header and the content. I guess the expected behaviour would be that the header resets to max height when switching to tab B.

Alt Text

@jnsvu jnsvu added the bug Something isn't working label Nov 29, 2020
@andreialecu
Copy link
Collaborator

I'm also running into this and I'm curious how to solve it.

Since the user can see part of other tabs while swiping, I'm not sure how to visually handle this.

A potential solution might be to fix the gap up top so the tab content starts aligned to the top. Then once the gesture is released, the header might pop in and the tab content would move down.

PedroBern added a commit that referenced this issue Nov 30, 2020
@PedroBern
Copy link
Owner

PedroBern commented Nov 30, 2020

EDITED: fixed in v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants