-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Combat issues #120
Merged
Merged
Fix: Combat issues #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New field to indicate how many alive player and gym loomies still alive
Check the user and the gym both has loomies before generating the combat token
PedroChaparro
added
bug
Something isn't working
battle
gymnasium
item inventory
loomie inventory
labels
Apr 24, 2023
PedroChaparro
requested review from
Woynert,
SilviaPabon and
andres123dbh
as code owners
April 24, 2023 18:34
Replace damanage with damage
Send the item id and item serial to the client.
Send t he type and message as payload instead of message to provide more information
Woynert
approved these changes
Apr 25, 2023
SilviaPabon
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix new issues from #108.
UPDATE_USER_LOOMIE_HP
andUPDATE_GYM_LOOMIE_HP
to send the attack value and notify if it was critical.