Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Combat issues #120

Merged
merged 13 commits into from
Apr 25, 2023
Merged

Fix: Combat issues #120

merged 13 commits into from
Apr 25, 2023

Conversation

PedroChaparro
Copy link
Owner

@PedroChaparro PedroChaparro commented Apr 24, 2023

Fix new issues from #108.

  • New fields on UPDATE_USER_LOOMIE_HP and UPDATE_GYM_LOOMIE_HP to send the attack value and notify if it was critical.
  • Check the user and the gym both has Loomies before generating the combat token.
  • Send the amount of alive player and gym Loomies in some messages (Combat start, use item, Loomies weakened)
  • Custom message to confirm the usage of an item sending it's id and serial.
  • Custom messages when an item cannot be used in a Loomie (Healing items).
  • Send if user owns the gym on endpoint GET gyms/{id}.

@PedroChaparro PedroChaparro changed the base branch from main to development April 24, 2023 13:45
@PedroChaparro PedroChaparro mentioned this pull request Apr 24, 2023
14 tasks
New field to indicate how many alive player and gym loomies still alive
Check the user and the gym both has loomies before generating the combat token
@PedroChaparro PedroChaparro marked this pull request as ready for review April 24, 2023 18:34
@PedroChaparro PedroChaparro marked this pull request as draft April 24, 2023 18:41
@SilviaPabon SilviaPabon marked this pull request as ready for review April 25, 2023 22:44
@SilviaPabon SilviaPabon merged commit e0d5829 into development Apr 25, 2023
2 checks passed
@SilviaPabon SilviaPabon deleted the fix/combat-II branch April 25, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants