-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vista recuperar contraseña #53
Conversation
Includes code reset password page and reset password page (validates a correct password as in signup page). Also includes 2 requests to Api,
Fixing linter warnings of StackNavigation, making optional some variables in EmailValidation and NewCode Pages
TouchableWithoutFeedback and components become in a reusable component
@PedroChaparro Tell me what do you think 🤔 about the new changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a security vulnerability with the current password reset implementation. See PedroChaparro/loomies-backend#78.
Aside from that I've found some usability issues:
- There is no clear indication where you must put the code or where to put the password.
- There is not a second field to confirm the password.
- I suggest using placeholders or labels like "Security code here" "Password here" "Confirm password".
@Woynert, The |
@PedroChaparro That should be checked only on the client side. Yes, ideally it should be added to the Sign Up form. |
Adding input for confirm password and changing placeholder messages in reset password page
@Woynert and @PedroChaparro I made the requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
I noticed there is not an issue for logout so I created it #58.
Also add more margin from the bottom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gw
Includes: