Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vista recuperar contraseña #53

Merged
merged 10 commits into from
Apr 4, 2023
Merged

Vista recuperar contraseña #53

merged 10 commits into from
Apr 4, 2023

Conversation

SilviaPabon
Copy link
Collaborator

@SilviaPabon SilviaPabon commented Mar 27, 2023

Includes:

  • Reset Password Page (this view is to request a code with the email)
    image
  • Change Password View (with the code sended to the email, this page allows insert the code and change the password)
    image
  • Reset Password from profile page (link to 2 previous pages) (This add some advances with profile page, but is not finished yet)
    image

Includes code reset password page and reset password page (validates a correct password as in signup page). Also includes 2 requests to Api,
@SilviaPabon SilviaPabon added frontend Auth Authentication / user session labels Mar 27, 2023
@SilviaPabon SilviaPabon self-assigned this Mar 27, 2023
src/pages/Profile.tsx Show resolved Hide resolved
src/pages/Profile.tsx Outdated Show resolved Hide resolved
src/pages/ChangePasswordView.tsx Show resolved Hide resolved
src/pages/Profile.tsx Outdated Show resolved Hide resolved
src/pages/Profile.tsx Outdated Show resolved Hide resolved
Fixing linter warnings of StackNavigation, making optional some variables in EmailValidation and NewCode Pages
TouchableWithoutFeedback and components become in a reusable component
@SilviaPabon
Copy link
Collaborator Author

SilviaPabon commented Mar 28, 2023

  1. The icons and the texts are using different text colors. I think it's better to use the same for all, try with "#5c5c5c".
  2. Can you separate this as a reusable component? Maybe the component can receive the icon name, the text to display and the name of the view to redirect.

@PedroChaparro Tell me what do you think 🤔 about the new changes!

Copy link
Collaborator

@Woynert Woynert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a security vulnerability with the current password reset implementation. See PedroChaparro/loomies-backend#78.

Aside from that I've found some usability issues:

  • There is no clear indication where you must put the code or where to put the password.
  • There is not a second field to confirm the password.
  • I suggest using placeholders or labels like "Security code here" "Password here" "Confirm password".

image

@PedroChaparro
Copy link
Owner

* There is not a second field to confirm the password.

@Woynert, The /session/signup endpoint and the Signup page on the client neither have that field, should we add it?

@Woynert
Copy link
Collaborator

Woynert commented Mar 30, 2023

@Woynert, The /session/signup endpoint and the Signup page on the client neither have that field, should we add it?

@PedroChaparro That should be checked only on the client side. Yes, ideally it should be added to the Sign Up form.

Adding input for confirm password and changing placeholder messages in reset password page
@SilviaPabon
Copy link
Collaborator Author

SilviaPabon commented Apr 3, 2023

There is a security vulnerability with the current password reset implementation. See PedroChaparro/loomies-backend#78.

Aside from that I've found some usability issues:

  • There is no clear indication where you must put the code or where to put the password.
  • There is not a second field to confirm the password.
  • I suggest using placeholders or labels like "Security code here" "Password here" "Confirm password".

image

@Woynert and @PedroChaparro I made the requested changes
image

Copy link
Collaborator

@Woynert Woynert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
I noticed there is not an issue for logout so I created it #58.

Copy link
Owner

@PedroChaparro PedroChaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gw

@PedroChaparro PedroChaparro merged commit cc814d4 into development Apr 4, 2023
1 check passed
@PedroChaparro PedroChaparro deleted the feat/reset-pass branch April 4, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auth Authentication / user session frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants