Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login auth doesn't work #44

Closed
soullivaneuh opened this issue Nov 14, 2014 · 2 comments
Closed

Login auth doesn't work #44

soullivaneuh opened this issue Nov 14, 2014 · 2 comments

Comments

@soullivaneuh
Copy link

Login doesn't work.

I think is caused by these line: https://github.com/PeeHaa/OpCacheGUI/blob/master/src/OpCacheGUI/Auth/User.php#L93-L95

Why return immediatly false? If my IP is not white-listed, the auth check will be never processed isn't it?

@PeeHaa
Copy link
Owner

PeeHaa commented Nov 14, 2014

Hi,

what do you mean. Unless I am misunderstanding you what is happening it the expected result?

As in: if you ip address is not whitelisted it should never process the credentials because access is denied either way.

If my IP is not white-listed, the auth check will be never processed isn't it?

Yes correct, which is by design.

If you think there is an error/bug somewhere I need some more information besides the fact that login doesn't work.

What does your config look like (the username / password / whitelist part)?

  • You should obfuscate the password hash when sharing the code.

@soullivaneuh
Copy link
Author

Ok I misunderstand the app design. I was thinking that if ip not authorized, then process password auth.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants