Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): add credentials loading mechanism using sdk config #1507

Merged
merged 25 commits into from
Apr 23, 2024

Conversation

iamKunalGupta
Copy link
Contributor

@iamKunalGupta iamKunalGupta commented Mar 19, 2024

Important function is GetAWSCredentialsProvider in flow/connectors/utils/aws.go

Order (in descending preference):

  1. Peer Credentials
  2. Explicit PEERDB_<CONNECTOR-NAME>_AWS_CREDENTIALS_<AWS-ENV-NAME> like PEERDB_CLICKHOUSE_AWS_CREDENTIALS_AWS_ACCESS_KEY_ID
  3. Default creds loaded by AWS sdk

Pending Items:

  • Resolve TODOs
  • Clickhouse Test - ONLY WORKS WITH versions after 18th March 2024
  • Snowflake Test
  • @iskakaushik this is blocked until query s3 with select and aws credentials ClickHouse/ClickHouse#61230 gets to a stable version of clickhouse.
  • Retest:
    • incompatible version check

      image
    • compatible version check

      image
  • Check what version clickhouse cloud is currently on
    • Most customers are on 24.2
  • Run a long test for 1 day to make sure creds are refreshed

@iamKunalGupta iamKunalGupta requested review from Amogh-Bharadwaj, serprex and iskakaushik and removed request for Amogh-Bharadwaj March 20, 2024 13:39
@iamKunalGupta iamKunalGupta changed the title feat(aws): add credentials loading mechanism using sdk config WIP: feat(aws): add credentials loading mechanism using sdk config Mar 20, 2024
@iamKunalGupta iamKunalGupta changed the title WIP: feat(aws): add credentials loading mechanism using sdk config [WIP] feat(aws): add credentials loading mechanism using sdk config Mar 20, 2024
@iskakaushik
Copy link
Contributor

@iamKunalGupta can you file an issue to make an env param PEERDB_DEFAULT_STAGE_LOCATION=<local | s3> and add that to your queue please?

@iamKunalGupta
Copy link
Contributor Author

@iamKunalGupta can you file an issue to make an env param PEERDB_DEFAULT_STAGE_LOCATION=<local | s3> and add that to your queue please?

@iskakaushik this will lead to issues where s3 staging is supported but not required, like snowflake. It will add additional costs and overhead if enabled by default.

@iskakaushik
Copy link
Contributor

@iamKunalGupta this could be useful for customers who wish to retain the raw streams of CDC for long periods of time, hence having the option would be nice.

@iamKunalGupta iamKunalGupta changed the title [WIP] feat(aws): add credentials loading mechanism using sdk config feat(aws): add credentials loading mechanism using sdk config Apr 23, 2024
@iamKunalGupta
Copy link
Contributor Author

Tested:
image

@iamKunalGupta iamKunalGupta merged commit 0f5f9ed into main Apr 23, 2024
9 checks passed
@iamKunalGupta iamKunalGupta deleted the fix/aws-change-creds-load-flow branch April 23, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants