parallelized lua script execution with serialized output #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
reviewed
Apr 13, 2024
|
This currently spawns a goroutine for each message. It could be optimized to only spawn 1 goroutine per lua.LState (edit: optimized in commit removing puddle) |
serprex
commented
Apr 14, 2024
| } | ||
|
|
||
| func LuaPoolJob(ctx context.Context, pool LPool, wait <-chan struct{}, f func(*lua.LState, <-chan struct{})) (chan struct{}, error) { | ||
| res, err := pool.Acquire(ctx) | ||
| func (pool *LPool[T]) Spawn() error { |
There was a problem hiding this comment.
While it'd be fine to spin up a constant N goroutines, the correct amount will depend on the script, making it better to specify that kind of knob on the mirror instead of environment
Instead Spawn is called when messages aren't being waited on, this way an environment can set parallelism to some good amount for the vcores available & fast scripts will only create as many goroutines as necessary to keep up with record ingestion
serprex
commented
Apr 14, 2024
serprex
force-pushed
the
lua-pool
branch
3 times, most recently
from
51e0b76
to
651060f
Compare
iskakaushik
approved these changes
Apr 15, 2024
serprex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.