Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch connector for QRep #1618

Merged
merged 8 commits into from
Apr 17, 2024
Merged

Elasticsearch connector for QRep #1618

merged 8 commits into from
Apr 17, 2024

Conversation

heavycrystal
Copy link
Contributor

Current limitations:

  1. doesn't support upsert with multiple key columns
  2. need to evaluate what types are supported as an upsert key
  3. basic types tested, need to check the rest
  4. no flow tests yet
  5. doesn't support index creation, so we need to disable create table on destination

serprex
serprex reviewed Apr 16, 2024
View reviewed changes
flow/connectors/core.go Outdated Show resolved Hide resolved
@serprex
Copy link
Member

serprex commented Apr 16, 2024

Approving since it looks alright & isn't impactful to existing code, but could use an e2e test

@heavycrystal
Copy link
Contributor Author

issue for E2E tests filed as #1621

@heavycrystal heavycrystal merged commit b8a7017 into main Apr 17, 2024
12 checks passed
@heavycrystal heavycrystal deleted the life-in-elastic-its-fantastic branch April 17, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serprex serprex serprex approved these changes

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heavycrystal @serprex