Queues: communicate flushes back to source in order to keep slot size down #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… down This is particularly important, as to reduce reconnections queues should be given day long sync batches
serprex
commented
Apr 18, 2024
| @@ -226,11 +225,11 @@ func (c *KafkaConnector) SyncRecords(ctx context.Context, req *model.SyncRecords | |||
| if err := c.client.Flush(ctx); err != nil { | |||
| c.logger.Warn("[kafka] flush error", slog.Any("error", err)) | |||
| continue | |||
| } else if lastSeen > lastUpdatedOffset { | |||
| } else if lastSeen > req.ConsumedOffset.Load() { | |||
There was a problem hiding this comment.
This update seems a bit repetitive, maybe it'd be better as a shared method, but fine to leave for now
|
Screenshot of lag decreasing while sync batch ongoing with a small amount of ingestion |
heavycrystal
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly important for queues, as to reduce reconnections long sync batches are desirable