XMIN for Query Replication #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -53,6 +53,14 @@ func compareValues(prevEnd interface{}, start interface{}) int { | |||
| return 0 | |||
| } | |||
| } | |||
| case uint32: //xmin | |||
| if prevEnd.(uint32) < uint32(v) { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unnecessary conversion (unconvert)
| case uint32: //xmin | ||
| if prevEnd.(uint32) < uint32(v) { | ||
| return -1 | ||
| } else if prevEnd.(uint32) > uint32(v) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unnecessary conversion (unconvert)
Amogh-Bharadwaj
force-pushed
the
xmin-for-qrep
branch
from
cf1b58c
to
0794778
Compare
iskakaushik
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You must type-cast the
xmincolumn in the query of your QRep create-mirror command :Fixes #397