e2e.GoWorkflow utility function to always couple goroutine & workflow execution #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orkflow execution Also tune timeouts on mock workflow environment
serprex
force-pushed
the
fix-wg-go-e2e
branch
from
3117c82
to
d2f9bb5
Compare
serprex
commented
Dec 29, 2023
| @@ -317,6 +318,18 @@ func RunXminFlowWorkflow(env *testsuite.TestWorkflowEnvironment, config *protos. | |||
| env.ExecuteWorkflow(peerflow.XminFlowWorkflow, config, state) | |||
| } | |||
|
|
|||
| // Execute fn in parallel with ExecuteWorkflow, returns when both complete | |||
| func GoWorkflow(fn func(), env *testsuite.TestWorkflowEnvironment, workflowFn interface{}, args ...interface{}) { | |||
| wg := sync.WaitGroup{} | |||
There was a problem hiding this comment.
tempted to make this a chan struct{} & then put a 1 minute timeout on channel being closed after ExecuteWorkflow finishes
|
Looks like this is uncovering hanging problems that were getting by in tests: |
iskakaushik
approved these changes
Dec 29, 2023
|
With #980 I'm moving things towards not using WaitGroup at all, instead workflow never ends & goroutine cancels it when done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tune timeouts on mock workflow environment
Also create
.editorconfig