-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DROP MIRROR support for PG, BQ and SF #93
Conversation
flow/connectors/postgres/postgres.go
Outdated
if err != nil { | ||
return fmt.Errorf("error starting transaction for flow cleanup: %w", err) | ||
} | ||
defer pullFlowCleanupTx.Rollback(c.ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Error return value of pullFlowCleanupTx.Rollback
is not checked (errcheck)
if err != nil { | ||
return fmt.Errorf("unable to begin transaction for sync flow cleanup: %w", err) | ||
} | ||
defer syncFlowCleanupTx.Rollback() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Error return value of syncFlowCleanupTx.Rollback
is not checked (errcheck)
This PR adds support for dropping mirrors, via the custom DROP MIRROR SQL command. Dropping a mirror requires handling the following: