Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display file size in human readable form #490

Merged
merged 2 commits into from
Apr 21, 2023
Merged

display file size in human readable form #490

merged 2 commits into from
Apr 21, 2023

Conversation

kevodwyer
Copy link
Member

No description provided.

ianopolous
ianopolous reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@ianopolous ianopolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think unfortunately we have to use the non binary version here, as most people won't understand KiB.

@kevodwyer
Copy link
Member Author

I think unfortunately we have to use the non binary version here, as most people won't understand KiB.

We already use KiB, MiB etc everywhere. Screenshot shows folder size and account size.

Screenshot 2023-04-21 at 16 09 24

@ianopolous ianopolous merged commit 389be51 into master Apr 21, 2023
@ianopolous
Copy link
Member

Closes Peergos/Peergos#1021

@kevodwyer kevodwyer deleted the fix/drive-file-size-display branch April 28, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianopolous ianopolous ianopolous left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevodwyer @ianopolous