Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioning in anticipation of the general Peerunity release #57

Merged
merged 5 commits into from
May 23, 2014
Merged

Update versioning in anticipation of the general Peerunity release #57

merged 5 commits into from
May 23, 2014

Conversation

brossi
Copy link

@brossi brossi commented May 22, 2014

Fixes #56 - Update client name, version number for the next release of Peerunity. Clean up references for Bitcoin and Peercoin's reference versions.

…f Peerunity. Clean up references for Bitcoin and Peercoin's reference versions.
@glv2
Copy link
Collaborator

glv2 commented May 23, 2014

I don't know if you noticed that the version numbers are also in the files peerunity.pro, share/setup.nsi, doc/README and doc/README_windows.txt.
These should probably also be updated.

@brossi
Copy link
Author

brossi commented May 23, 2014

Yes, they should. I'll get those added this morning and fold them into the pull request. Thanks!

@brossi
Copy link
Author

brossi commented May 23, 2014

@glv2 - while updating share/setup.nsi, I noticed a block of commented code that looks like it could be removed:

# bitcoin: URI handling disabled for 0.6.0
#    WriteRegStr HKCR "bitcoin" "URL Protocol" ""
#    WriteRegStr HKCR "bitcoin" "" "URL:Bitcoin"
#    WriteRegStr HKCR "bitcoin\DefaultIcon" "" $INSTDIR\bitcoin-qt.exe
#    WriteRegStr HKCR "bitcoin\shell\open\command" "" '"$INSTDIR\bitcoin-qt.exe" "$$1"'

Do you happen to know if it's safe to clean that out so that it isn't mistakenly used in the future, or alternatively, if it's something that we should keep, but update with Peerunity-relevant content and retain for a future point where there is a Peerunity URL protocol?

@brossi
Copy link
Author

brossi commented May 23, 2014

Regarding doc/README.md and doc/README_windows.txt, I've added a separate ticket to update the content (#58).

@glv2
Copy link
Collaborator

glv2 commented May 23, 2014

It's probably safe to remove the URI handling registry keys (unless somebody has plans for a URI protocol, but I've never heard anyone talk about that).

@brossi
Copy link
Author

brossi commented May 23, 2014

Error during build encountered. Relates to a missed constant in version.h.

"src/version.h:51:18: error: redefinition of ‘const int CLIENT_VERSION’ src/version.h:22:18: error: ‘const int CLIENT_VERSION’ previously defined here In file included from src/serialize.h:24:0"

brossi added a commit that referenced this pull request May 23, 2014
Update versioning in anticipation of the general Peerunity release
@brossi brossi merged commit 4bb1b1d into Peerunity:master May 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update versioning for the upcoming 0.1.0 release
2 participants