Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced UInt64 with UnsignedLong #188

Merged
merged 4 commits into from
Jan 13, 2019
Merged

Replaced UInt64 with UnsignedLong #188

merged 4 commits into from
Jan 13, 2019

Conversation

craigwilliams84
Copy link
Contributor

PR Description

Replaced UInt64 with UnsignedLong from Guava

Fixed Issue(s)

Fixes #108

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jrhea
Copy link
Contributor

jrhea commented Jan 13, 2019

@craigwilliams84 thanks for doing this!! It looks good to me at a glance. I am going to assign the review to @schroedingerscode to look at though.

@schroedingerscode schroedingerscode added enhancement 🕵️‍♀️ New feature or request code style 💅 This issue or pull request makes our code prettier labels Jan 13, 2019
@schroedingerscode schroedingerscode self-assigned this Jan 13, 2019
@schroedingerscode
Copy link
Contributor

schroedingerscode commented Jan 13, 2019 •
edited
Loading

Thanks for the PR @craigwilliams84. I'll let @jrhea get all the 3 way merge conflicts sorted after his restructuring, then I'll take a look.

@jrhea
Copy link
Contributor

jrhea commented Jan 13, 2019

@schroedingerscode should be good 2 go. Thanks dude

schroedingerscode
schroedingerscode approved these changes Jan 13, 2019
View reviewed changes
Copy link
Contributor

@schroedingerscode schroedingerscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for your help!

@schroedingerscode schroedingerscode merged commit 172ed7c into Consensys:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schroedingerscode schroedingerscode schroedingerscode approved these changes

Assignees

@schroedingerscode schroedingerscode

Labels
code style 💅 This issue or pull request makes our code prettier enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@craigwilliams84 @CLAassistant @jrhea @schroedingerscode