Detailed msg when log filter not found (#428)

PegaSysEng · Dec 17, 2018 · e62d68e · e62d68e
1 parent 0e0aa98
commit e62d68e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/...c/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/internal/methods/EthGetFilterLogs.java b/...c/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/internal/methods/EthGetFilterLogs.java
@@ -48,6 +48,6 @@ public JsonRpcResponse response(final JsonRpcRequest request) {
       return new JsonRpcSuccessResponse(request.getId(), new LogsResult(logs));
     }
 
-    return new JsonRpcErrorResponse(request.getId(), JsonRpcError.FILTER_NOT_FOUND);
+    return new JsonRpcErrorResponse(request.getId(), JsonRpcError.LOGS_FILTER_NOT_FOUND);
   }
 }
diff --git a/.../src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/internal/response/JsonRpcError.java b/.../src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/internal/response/JsonRpcError.java
@@ -28,6 +28,7 @@ public enum JsonRpcError {
 
   // Filter & Subscription Errors
   FILTER_NOT_FOUND(-32000, "Filter not found"),
+  LOGS_FILTER_NOT_FOUND(-32000, "Logs filter not found"),
   SUBSCRIPTION_NOT_FOUND(-32000, "Subscription not found"),
   NO_MINING_WORK_FOUND(-32000, "No mining work available yet"),
 

diff --git a/...st/java/tech/pegasys/pantheon/ethereum/jsonrpc/internal/methods/EthGetFilterLogsTest.java b/...st/java/tech/pegasys/pantheon/ethereum/jsonrpc/internal/methods/EthGetFilterLogsTest.java
@@ -88,7 +88,7 @@ public void shouldReturnErrorWhenMissingFilterId() {
   public void shouldReturnFilterNotFoundWhenFilterManagerReturnsNull() {
     final JsonRpcRequest request = requestWithFilterId("NOT FOUND");
     final JsonRpcResponse expectedResponse =
-        new JsonRpcErrorResponse(null, JsonRpcError.FILTER_NOT_FOUND);
+        new JsonRpcErrorResponse(null, JsonRpcError.LOGS_FILTER_NOT_FOUND);
     when(filterManager.logs(eq("NOT FOUND"))).thenReturn(null);
 
     final JsonRpcResponse response = method.response(request);