This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[MINOR] Suicides mixing coinbase #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smatthewenglish
force-pushed
the
suicides-mixing-coinbase
branch
from
1df6fd0
to
5660675
Compare
smatthewenglish
changed the title
smatthewenglish
removed
the
work in progress
smatthewenglish
force-pushed
the
suicides-mixing-coinbase
branch
from
f3ff785
to
740949d
Compare
smatthewenglish
force-pushed
the
suicides-mixing-coinbase
branch
from
740949d
to
5a1763e
Compare
smatthewenglish
changed the title
ajsutton
approved these changes
Oct 19, 2018
| @@ -79,24 +79,6 @@ private static TransactionProcessor transactionProcessor(final String name) { | |||
| if (EIPS_TO_RUN.isEmpty()) { | |||
| params.blacklistAll(); | |||
| } | |||
| // Known incorrect test. | |||
| params.blacklist("RevertPrecompiledTouch-(EIP158|Byzantium)"); | |||
There was a problem hiding this comment.
This one really is a known bad test and ignored in other clients too. Probably shouldn't be enabled.
| // Gas integer value is too large to construct a valid transaction. | ||
| params.blacklist("OverflowGasRequire"); | ||
| // Consumes a huge amount of memory | ||
| params.blacklist("static_Call1MB1024Calldepth-(Byzantium|Constantinople)"); |
There was a problem hiding this comment.
This one definitely shouldn't be enabled - it passes, but uses huge amounts of memory which causes problems with the docker setup in CI.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.