This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Pipeline chain download - target selection #1196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…astSynchronizer and FullSynchronizer to FastDownloaderFactory and FullDownloaderFactory.
…wnloader-abstraction
…wnloaderFactory to FullSyncDownloader since it doesn't actually need a factory.
…pleted (SyncTargetManager would just blindly re-use it).
ajsutton
force-pushed
the
pipeline-download-target-selection
branch
from
81d5b5a
to
cfcb58e
Compare
…-download-target-selection
|
Superseded by #1203 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Begins implementation of a pipeline based chain downloader.
Builds on #1194 so the new chain download process isn't currently in use (but unfortunately that makes the diff quite large).
PipelineChainDownloader,DownloadPipelineFactoryandPipelineChainDownloaderTestare the new changes in this PR.So far only the process of selecting a sync target, handling failures and cancellation are implemented. The actual pipeline to download and import blocks once a sync target is selected is behind an interface which doesn't yet have an available implementation.