This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fix loop syntax in runPantheonPrivateNetwork.sh #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`while (( "$#" ))` does not work in some shells.
ajsutton
approved these changes
Nov 4, 2018
shemnon
pushed a commit
to shemnon/pantheon
that referenced
this pull request
Nov 14, 2018
`while (( "$#" ))` does not work in some shells.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Changed
whileloop syntax to the POSIX test expression. TherunPantheonPrivateNetwork.shwill not ignore its options.Fixed Issue(s)
while (( "$#" ))in therunPantheonPrivateNetwork.shdoes not work in some shells. For example, in/bin/shon boot2docker (Tiny Core Linux based on busybox), the following error occured:The
runPantheonPrivateNetwork.shcontinues to process after the error, but its options,--skip-build --rpc-port 1234 --ws-port 5678, are ignored.