This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Ibft Integration Tests - Spurious Behaviour #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds additional tests which fall outside of the existing suite, and target spuriously behaved peers - i.e. illegal seals, illformed RLP data etc.
CjHare
reviewed
Jan 21, 2019
| createSignedCommitPayload( | ||
| roundId, proposedBlock, context.getLocalNodeParams().getNodeKeyPair()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Do these two illegal RLP cover the control flow if junk RLP (RLP that doesn't 'fit' into the expected data structure)?
There was a problem hiding this comment.
The first test ensures RLP which doesn't match a given message ID doesn't prevent ongoing IBFT operation.
The second test ensures that if a msg with a message-ID which is not for IBFT is received, that it is discarded.
The last test ensures if the seal in a commit msg is bad, that it is ignored.
CjHare
reviewed
Jan 21, 2019
CjHare
approved these changes
Jan 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds additional tests which fall outside of the existing
suite, and target spuriously behaved peers - i.e. illegal seals,
illformed RLP data etc.