-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transaction contention caused by serializable transaction isolation level #237
Conversation
...rotection/src/main/java/tech/pegasys/web3signer/slashingprotection/DbSlashingProtection.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - minor nit-pick suggestions.
@@ -23,6 +23,7 @@ | |||
import org.jdbi.v3.core.Jdbi; | |||
import org.jdbi.v3.core.argument.Arguments; | |||
import org.jdbi.v3.core.mapper.ColumnMappers; | |||
import org.jdbi.v3.core.transaction.SerializableTransactionRunner; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need this for the register validators as it's still using serializable
This fixes an issue where failures were occurring when on updating the slashing protection db.