Feat/morpho is borrowing any #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xEinCodes
approved these changes
Jun 15, 2023
| @@ -97,12 +97,10 @@ contract MorphoAaveV2ATokenAdaptor is BaseAdaptor, MorphoRewardHandler { | |||
| /** | |||
| * @notice Uses configuration data to determine if the position is liquid or not. | |||
| */ | |||
There was a problem hiding this comment.
This natSpec comment is not longer accurate
0xEinCodes
reviewed
Jun 16, 2023
| ) public view override returns (uint256) { | ||
| bool isLiquid = abi.decode(configData, (bool)); | ||
| if (!isLiquid) return 0; | ||
| function withdrawableFrom(bytes memory adaptorData, bytes memory) public view override returns (uint256) { |
There was a problem hiding this comment.
@kingofclubstroyDev comment is right. Also please add params descriptions.
0xEinCodes
requested changes
Jun 16, 2023
0xEinCodes
approved these changes
Jun 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Morpho Aave V2 debt token adaptor logic so that calling the strategist repay function will always repay the full amount of debt, where as before it would sometimes leave 1 wei of debt behind.
In addition to the above it also removes the
isLiquidconfiguration bool from the Morpho Aave V2 aToken adaptor, and instead reads the cellarsuserMarketsto determine if the cellar has any active loans. If the cellar has no active loans, the aToken position is liquid, otherwise the aToken position is illiquid.