Skip to content

Commit

Permalink
Rename SITESUBTITLE to SITE_SUBTITLE
Browse files Browse the repository at this point in the history
  • Loading branch information
@talha131
talha131 committed Apr 21, 2014
1 parent 06acaee commit e479ce7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Version 2.0 (under development)
* Add Disqus comments to Pages
* All customizable variables consolidated in a single `_defaults.html`, making
it easier for you to customize or even *localize* the theme
* Rename `SITESUBTITLE` to `SITE_SUBTITLE`

Performance
-----------
Expand Down
6 changes: 3 additions & 3 deletions templates/_includes/_defaults.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,10 @@
{% endif %}

{# It is displayed along with the SITENAME in the footer of every page #}
{% if not SITESUBTITLE %}
{% set SITESUBTITLE = '' %}
{% if not SITE_SUBTITLE %}
{% set SITE_SUBTITLE = '' %}
{% else %}
{% set SITESUBTITLE = SITESUBTITLE %}
{% set SITE_SUBTITLE = SITE_SUBTITLE %}
{% endif %}

{# Set it to True to display favicon and speed dial icon. Also make sure that
Expand Down
6 changes: 3 additions & 3 deletions templates/_includes/footer.html
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<footer>
<div id="footer">
<ul class="footer-content">
{% from '_includes/_defaults.html' import SITESUBTITLE with context %}
{% if SITESUBTITLE %}
<li class="elegant-subtitle"><span class="site-name">{{ SITENAME }}</span> - {{ SITESUBTITLE }}</li>
{% from '_includes/_defaults.html' import SITE_SUBTITLE with context %}
{% if SITE_SUBTITLE %}
<li class="elegant-subtitle"><span class="site-name">{{ SITENAME }}</span> - {{ SITE_SUBTITLE }}</li>
{% endif %}
{% from '_includes/_defaults.html' import SITE_LICENSE with context %}
{% if SITE_LICENSE %}
Expand Down

2 comments on commit e479ce7

@calfzhou
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any special reason to make this change? In pelican's document, the default theme uses SITESUBTITLE.

@talha131
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed it to make sure it conforms with rest of the Elegant variables which use an underscore _. I was under the impression that Elegant created this variable, I wasn't aware other themes too have this variable.

I guess now I should revert this commit to make it consistent with other themes.

Please sign in to comment.