Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "{{ SITEURL }}" back. #65

Merged
merged 1 commit into from
Nov 12, 2013

Conversation

calfzhou
Copy link
Contributor

There are several missing {{ SITEURL}}, they break some links when the site is not published to a root folder.

This PR add them back :)

@talha131
Copy link
Member

Thank you 👍

Does it break only tags, categories, and archives pages only? For example, we show a next and previous article links at the bottom of every article. Shouldn't they too be affected by it?

What about links to article that appear on front page and archives page? Don't they break too?

@calfzhou
Copy link
Contributor Author

It only breaks these pages. I've checked every template file.

@talha131 talha131 merged commit 4f5160c into Pelican-Elegant:master Nov 12, 2013
@calfzhou calfzhou deleted the siteurl branch November 13, 2013 03:30
talha131 pushed a commit to talha131/elegant that referenced this pull request Jun 9, 2019
fixes #2 

I left a few instances where Talha’s homepage or profile is still used, where I thought it does not break anything and does not confuse the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants