Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand endpoints #37

Merged
merged 4 commits into from
May 11, 2024
Merged

Expand endpoints #37

merged 4 commits into from
May 11, 2024

Conversation

turetske
Copy link
Collaborator

@turetske turetske commented May 9, 2024

This closes three issues:

  1. Closes Use Federation URL for instead of the director URL #14 : The "pelican://federation-disc-url" to discover the federation metadata and the director endpoint.
  2. Closes Add a direct-reads function #33 : Adds a direct-reads functionality to the code
  3. Closes Allow user to specify a cache #34 : Allows the user to specify a cache to be used

@turetske
Expanded endpoint specification and added federation discovery
bd959c8 
	-- Users can now specify whether to read directly from the origin rather than stagins
	-- Users can specify a cache to stage data into
	-- The PelicanFileSystem now takes in a pelican://<federation> url and performs metadata discovery to get the directorUrl
@turetske
Adjusted readme headers/note flag
93d7e35
@turetske turetske requested a review from bbockelm May 9, 2024 20:51
bbockelm
bbockelm requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments inline.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/pelicanfs/core.py Outdated Show resolved Hide resolved
src/pelicanfs/core.py Outdated Show resolved Hide resolved
src/pelicanfs/core.py Outdated Show resolved Hide resolved
src/pelicanfs/core.py Outdated Show resolved Hide resolved
src/pelicanfs/core.py Outdated Show resolved Hide resolved
src/pelicanfs/core.py Outdated Show resolved Hide resolved
@bbockelm bbockelm self-assigned this May 11, 2024
@bbockelm
Merge branch 'main' into expand-endpoints
5412165
@bbockelm
Address review comments
5153b7b 
Also adds unit test coverage for the preferred_caches and the direct_read
options.
@bbockelm bbockelm self-requested a review May 11, 2024 22:37
bbockelm
bbockelm approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbockelm bbockelm merged commit 9996cc0 into PelicanPlatform:main May 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbockelm bbockelm bbockelm approved these changes

Assignees

@bbockelm bbockelm

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@turetske @bbockelm