PROPFIND and glob fix #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turetske
force-pushed
the
use-propfind-for-ls
branch
3 times, most recently
from
8f08fd7
to
864432a
Compare
-- Moved glob to the top level to deal with potential '//' -- Added a get_dirlist_url function that uses PROPFIND -- Removed unused get_dirlist_host from the parser module
Also created a work-around for isdir and isfile
turetske
force-pushed
the
use-propfind-for-ls
branch
from
864432a
to
7a3a002
Compare
bbockelm
approved these changes
May 23, 2024
There was a problem hiding this comment.
Some minor items in the review -- please address them and merge.
I think the find & glob methods need better test coverage -- I'm concerned by the fact the tricky logic is around multiple subdirectories and we only have a test for a single level. Please open up a new issue as a follow-up.
…t_mapper' root
-- Renamed and made the _remove_hostname_from_path/s methods static methods
-- Added tests for _remove_hostname_from_paths
-- get_mapper now works with an absolute path rather than a url to a cache
Also added two example notebooks to show how things work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41
Closes #3
Closes #4
Closes #10
Relies on #42, so review that first.