-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Mbed Cloud 1.2.2 #16
Conversation
1.2.3 is going out this week, 1.2.4 at the end of the month. Which version did you test against? |
I tested against RR1.2.2-EA, based on latest release from https://github.com/ARMmbed/mbed-cloud-client-example-restricted against Mbed Cloud production (at https://portal.us-east-1.mbedcloud.com). |
Copy edit, mostly for active voice and consistent branding.
docs/4_connectivity.md
Outdated
|
||
To add these libraries to your project: | ||
<span class="notes">**Note about ESP8266 on NUCLEO boards:** On the NUCLEO boards, pins `D0` and `D1` are used for serial communication with the computer. Use pins `D8` (to ESP8266 TX) and `D2` (to ESP8266 RX) instead.</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Query: From a content perspective, is it correct to say "... The NUCLEO boards reserve pins D0
and D1
for serial communication ..." for active voice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's fine.
Copy edit for active voice and comma use.
Copy edit for consistent branding.
Copy edit for consistent branding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one query about changing a sentence to active voice. I also changed the older content that used the old branding to the newer branding. Nice work on this.
@janjongboom according to @senthilr there have been significant changes in Mbed Cloud that broke a lot of things. You might want to test against 1.2.4 (Senthil can probably point you at the right location). |
@iriark01 So the application connects fine against cloud production. It's still on 1.2.2 client version, but that is compatible with 1.2.4 cloud. |
Then I guess you can merge? |
Make the change to active voice proposed earlier.
@AnotherButler @iriark01 I'm not sure how to rebuild this doc for the cloud docs site. |
It autobuilds |
@peknis01 @AnotherButler @iriark01
Verified against Mbed Cloud 1.2 and the latest SDKs.