Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Mbed Cloud 1.2.2 #16

Merged
merged 7 commits into from
Oct 12, 2017
Merged

Update to Mbed Cloud 1.2.2 #16

merged 7 commits into from
Oct 12, 2017

Conversation

janjongboom
Copy link
Contributor

@janjongboom janjongboom commented Oct 3, 2017

@peknis01 @AnotherButler @iriark01

Verified against Mbed Cloud 1.2 and the latest SDKs.

@iriark01
Copy link
Contributor

iriark01 commented Oct 3, 2017

1.2.3 is going out this week, 1.2.4 at the end of the month. Which version did you test against?

@janjongboom
Copy link
Contributor Author

@iriark01

I tested against RR1.2.2-EA, based on latest release from https://github.com/ARMmbed/mbed-cloud-client-example-restricted against Mbed Cloud production (at https://portal.us-east-1.mbedcloud.com).

Copy edit, mostly for active voice and consistent branding.

To add these libraries to your project:
<span class="notes">**Note about ESP8266 on NUCLEO boards:** On the NUCLEO boards, pins `D0` and `D1` are used for serial communication with the computer. Use pins `D8` (to ESP8266 TX) and `D2` (to ESP8266 RX) instead.</span>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query: From a content perspective, is it correct to say "... The NUCLEO boards reserve pins D0 and D1 for serial communication ..." for active voice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's fine.

Amanda Butler added 3 commits October 6, 2017 10:22
Copy edit for active voice and comma use.
Copy edit for consistent branding.
Copy edit for consistent branding.
Copy link

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one query about changing a sentence to active voice. I also changed the older content that used the old branding to the newer branding. Nice work on this.

@iriark01
Copy link
Contributor

iriark01 commented Oct 7, 2017

@janjongboom according to @senthilr there have been significant changes in Mbed Cloud that broke a lot of things. You might want to test against 1.2.4 (Senthil can probably point you at the right location).

@janjongboom
Copy link
Contributor Author

@iriark01 So the application connects fine against cloud production. It's still on 1.2.2 client version, but that is compatible with 1.2.4 cloud.

@iriark01
Copy link
Contributor

Then I guess you can merge?

Make the change to active voice proposed earlier.
@janjongboom janjongboom merged commit d35421b into master Oct 12, 2017
@janjongboom
Copy link
Contributor Author

@AnotherButler @iriark01 I'm not sure how to rebuild this doc for the cloud docs site.

@iriark01
Copy link
Contributor

It autobuilds

@yennster yennster deleted the cloud_1.2.2 branch August 24, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants