Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error for Mbed TF-M V8M target (2) #91

Closed
wants to merge 1 commit into from

Conversation

ccli8
Copy link

@ccli8 ccli8 commented Aug 18, 2021

[x] I confirm this contribution is my own and I agree to license it with Apache 2.0.
[x] I confirm the moderators may change the PR before merging it in.
[x] I understand the release model prohibits detailed Git history and my contribution will be recorded to the list at the bottom of CONTRIBUTING.md.

Summary of changes

Continuing #88, this PR tries to fix more compile error for Mbed TF-M V8M target, usually without FLASHIAP. In arm_uc_config.h:

  1. Use DEVICE_FLASH as prerequisite to enable ARM_UC_FEATURE_PAL_FLASHIAP
  2. Use ARM_UC_FEATURE_PAL_FLASHIAP as prerequisite to enable ARM_UC_FEATURE_PAL_FILESYSTEM

@marcuschangarm

Fix compile error for Mbed TF-M V8M target, usually without FLASHIAP. In arm_uc_config.h:
1. Use DEVICE_FLASH as requirement to enable ARM_UC_FEATURE_PAL_FLASHIAP
2. Use ARM_UC_FEATURE_PAL_FLASHIAP as requirement to enable ARM_UC_FEATURE_PAL_FILESYSTEM
@marcuschangarm
Copy link

@ccli8 Thank you! I'll take a look!

@marcuschangarm
Copy link

@ccli8 I think it would be better to add a new section for PSA, once it is ready, so that is looks like the other configurations. For example:

#elif defined(UPDATE_CLIENT_STORAGE_PSA)
#define ARM_UC_FEATURE_PAL_FLASHIAP 0
#define ARM_UC_FEATURE_PAL_FLASHIAP_MCUBOOT 0
#define ARM_UC_FEATURE_PAL_BLOCKDEVICE 0
#define ARM_UC_FEATURE_PAL_FILESYSTEM 0
#define ARM_UC_FEATURE_PAL_LINUX 0
#define ARM_UC_FEATURE_PAL_RTL8195AM 0
#define ARM_UC_FEATURE_PAL_PSA 1

You could then name your implementation UPDATE_CLIENT_STORAGE_PSA and hide the code behind the define ARM_UC_FEATURE_PAL_PSA .

@ccli8
Copy link
Author

ccli8 commented Aug 20, 2021

With above modification, this PR is replaced with #92.

@marcuschangarm
Copy link

@ccli8 sounds good, lets close this PR and continue the conversation in the other one.

@ccli8
Copy link
Author

ccli8 commented Aug 23, 2021

Close because #92 will cover this one

@ccli8 ccli8 closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants