Add support for EMAC backhaul driver #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires ARMmbed/mbed-os#5944 |
SeppoTakalo
approved these changes
Jan 29, 2018
kjbracey
force-pushed
the
emac_support
branch
from
c4c008b
to
0579173
Compare
kjbracey
force-pushed
the
emac_support
branch
2 times, most recently
from
9c1e22b
to
94a6915
Compare
|
Reworked to use default network interface API. Still not switched the default to EMAC. Guess we should? |
|
Note EMAC K64F driver still suffers from "cable disconnect start-up jam" so would be a functional regression from Nanostack version. |
mikaleppanen
approved these changes
May 28, 2018
Add new EMAC backhaul driver option that uses new mbed OS 5.9 EMAC and default network interface APIs. This should work for any Ethernet EMAC driver, and can work with appropriately-engineered Wifi drivers - see README.md for more details.
EMAC changes increase static allocation, meaning we don't quite fit in an IAR K64F build any more.
No longer builds with mbed OS 5.9 due to collision with EMAC driver. That EMAC driver is now usable, so no need for the Nanostack one anyway.
Change JSON files to select EMAC driver, rather than native Nanostack. This is currently a minor functional regression for K64F - the EMAC driver doesn't start gracefully if the cable isn't connected.
|
FYI, it looks like this commit is causing the currently generated 5.8.6 patch release to not build, due to the new config options. Does this application still build in 5.8? |
|
@kjbracey-arm Changes for 5.9 should not land on master until 5.9 is released as this breaks 5.8 compatibility. Instead these changes should have gone on the OOB branch. Can you please do that and restore master to 5.8 compatibility. |
kjbracey
added a commit
that referenced
this pull request
Jun 5, 2018
kjbracey
added a commit
that referenced
this pull request
Jun 5, 2018
kjbracey
added a commit
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new EMAC backhaul driver option that uses new mbed OS 5.9 EMAC and default network interface APIs. This should work for any Ethernet EMAC driver, and can work with appropriately-engineered Wifi drivers - see README.md for more details.