Handle the case of no-access-to-localStorage. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!specialowner()) return false; | ||
| try { | ||
| if (!window.localStorage) return false; |
There was a problem hiding this comment.
Why did this need to get moved into the try/catch? Why didn't it work outside like it was before? And why didn't the try catch just deal with the inability to access localStorage?
|
It turns out window.localStorage already returns an object which can be prohibited - you don't need to dereference into the storage object to get the exception - it's enough just to get the outer object itself. So even writing (!window.localStorage) was enough to get the security exception. |
|
... In practice, this was occurring when running frame.pencilcode.net inside a frame where some security policy about localStorage access is applying. |
|
ok. I'm merging it now. |
theanandramakrishna
added a commit
that referenced
this pull request
May 28, 2014
Handle the case of no-access-to-localStorage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent visible exceptions from being thrown when window.localStorage access is prohibited.