Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to version 1.2.0 #28

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Bump to version 1.2.0 #28

merged 1 commit into from
Apr 5, 2018

Conversation

anarchivist
Copy link
Collaborator

No description provided.

mejackreed
mejackreed previously requested changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@mejackreed mejackreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we determined what tcramer semantically versions? Is this a feature add? Or a bug fix?

cc @penguin-direct

@mjgiarlo
Copy link
Member

mjgiarlo commented Apr 5, 2018

Yes, we follow semver. We should bump up 1.2.0.

Thanks for your contribution!

@anarchivist anarchivist changed the title Bump to version 1.1.1 Bump to version 1.2.0 Apr 5, 2018
@anarchivist
Copy link
Collaborator Author

Amended the commit to change the version to 1.2.0.

mejackreed
mejackreed approved these changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@mejackreed mejackreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mejackreed mejackreed merged commit 4510fe9 into master Apr 5, 2018
@mejackreed mejackreed deleted the bump-version branch April 5, 2018 13:43
@mjgiarlo
Copy link
Member

mjgiarlo commented Apr 5, 2018

@mejackreed @anarchivist 👏

I just released 1.2.0 to rubygems.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejackreed mejackreed mejackreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anarchivist @mjgiarlo @mejackreed