Revert the commit because of upgrading go-sqlite3 to 1.14.19
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit 031e41a is a temporary workaround to fix musl build error, and now to remove `CGO_CFLAGS="-D_LARGEFILE64_SOURCE"` for building docker image, because go-sqlite3 library was upgraded to `1.14.19` [^1] and the musl build was fixed in go-sqlite3 version `1.14.19` [^2]. This reverts commit 031e41a (refer PR #234). --- [^1]: commit hash ad6673b [^2]: mattn/go-sqlite3#1177
huiyifyj
added
enhancement ✨
Comment the `if` condition limitation of the main branch for 'deploy-docker' job temporarily, to build docker image CI/CD job in non-main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert
Fix build docker with sqlite3 musl error (#234)The commit 031e41a is a temporary workaround to fix musl build error.
Remove
CGO_CFLAGS="-D_LARGEFILE64_SOURCE"for building docker image.Because go-sqlite3 library was upgraded to
1.14.191 and the musl build was fixed in go-sqlite3 version1.14.192.This reverts commit 031e41a (refer PR #234).
Footnotes
commit hash ad6673b ↩
mattn/go-sqlite3#1177 ↩