Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BIDS-noncompliant m0z and cbf files #236

Merged
merged 1 commit into from Mar 15, 2023
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 15, 2023

Closes #175 and related to #214.

Changes proposed in this pull request

  • Do not collect m0scan (misspelled as MoScan) or DELTAM (not a BIDS suffix) files in collect_data. These files do not appear to be used by ASLPrep anyway.

Documentation that should be reviewed

@tsalo tsalo added the bug Something isn't working label Mar 15, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 77.77% and project coverage change: -0.04 ⚠️

Comparison is base (32a7fb2) 44.07% compared to head (4d84024) 44.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   44.07%   44.04%   -0.04%     
==========================================
  Files         130      130              
  Lines       12360    12376      +16     
==========================================
+ Hits         5448     5451       +3     
- Misses       6912     6925      +13     
Impacted Files Coverage Δ
aslprep/utils/bids.py 50.68% <75.00%> (+6.82%) ⬆️
aslprep/niworkflows/interfaces/bids.py 66.20% <100.00%> (ø)
aslprep/workflows/base.py 88.60% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo merged commit 8a358ff into PennLINC:main Mar 15, 2023
2 checks passed
@tsalo tsalo deleted the collect_data branch March 15, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'No "moz" images found' although present in BIDS directory
2 participants