Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode T1blood for some field strengths and use Zhang 2013 formula for others #243

Merged
merged 6 commits into from Apr 3, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 29, 2023

Closes #239.

Changes proposed in this pull request

  • For 1.5T and 3T data, set T1blood from Alsop 2015 (1.35 and 1.65, respectively). For other field strengths, use the Zhang 2013 formula.

@tsalo tsalo added the enhancement New feature or request label Mar 29, 2023
@tsalo tsalo marked this pull request as ready for review March 29, 2023 15:15
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch coverage: 63.48% and project coverage change: +0.50 🎉

Comparison is base (b1a516b) 45.09% compared to head (a5282b3) 45.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   45.09%   45.59%   +0.50%     
==========================================
  Files         129      132       +3     
  Lines       12302    12465     +163     
==========================================
+ Hits         5548     5684     +136     
- Misses       6754     6781      +27     
Impacted Files Coverage Δ
aslprep/interfaces/ge.py 24.35% <0.00%> (-1.26%) ⬇️
aslprep/workflows/base.py 88.60% <ø> (ø)
aslprep/tests/test_cli.py 72.58% <10.52%> (-27.42%) ⬇️
aslprep/workflows/asl/cbf.py 59.17% <36.25%> (-0.43%) ⬇️
aslprep/workflows/asl/gecbf.py 14.65% <42.85%> (+1.01%) ⬆️
aslprep/workflows/asl/qc.py 54.38% <54.38%> (ø)
aslprep/interfaces/cbf_computation.py 69.25% <62.16%> (-2.70%) ⬇️
aslprep/workflows/asl/plotting.py 65.45% <65.45%> (ø)
aslprep/utils/misc.py 66.27% <77.77%> (+2.72%) ⬆️
aslprep/tests/test_interfaces_cbf_computation.py 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo changed the title Set T1blood for 1.5T/3T data from Alsop 2015 and use Zhang 2013 formula for other field strengths Hardcode T1blood for some field strengths and use Zhang 2013 formula for others Mar 29, 2023
@tsalo tsalo merged commit 432576f into PennLINC:main Apr 3, 2023
20 checks passed
@tsalo tsalo deleted the t1blood branch April 4, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace T1blood formula from Zhang 2013 with values from Alsop 2015
2 participants