Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RepetitionTime with RepetitionTimePreparation #245

Merged
merged 6 commits into from Mar 30, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 29, 2023

Closes #242.

Changes proposed in this pull request

  • Use RepetitionTimePreparation instead of RepetitionTime for summaries. I decided to drop this change, since these summaries mostly generate plots that would break with irregular sampling.
  • Extract RepetitionTimePreparation from M0 volumes only for BASIL, rather than just using the general RepetitionTime from the ASL metadata.
  • Add RepetitionTimePreparation to output files' metadata. I kept RepetitionTime in there as well.
  • Patch the test data by replacing the current RepetitionTimePreparation values (0 for some reason) with the RepetitionTime values.

Do I need to perform STC with RepetitionTimePreparation or RepetitionTime? If the former, can 3dTShift work with an array of TRs?

@tsalo tsalo added the bug Something isn't working label Mar 29, 2023
I think it just makes more sense to use a single TR value for these.
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 64.07% and project coverage change: +0.53 🎉

Comparison is base (b1a516b) 45.09% compared to head (4565c9e) 45.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   45.09%   45.63%   +0.53%     
==========================================
  Files         129      132       +3     
  Lines       12302    12483     +181     
==========================================
+ Hits         5548     5697     +149     
- Misses       6754     6786      +32     
Impacted Files Coverage Δ
aslprep/interfaces/ge.py 24.35% <0.00%> (-1.26%) ⬇️
aslprep/workflows/asl/outputs.py 44.10% <ø> (ø)
aslprep/workflows/asl/stc.py 50.00% <ø> (ø)
aslprep/workflows/base.py 88.60% <ø> (ø)
aslprep/workflows/asl/cbf.py 59.17% <36.25%> (-0.43%) ⬇️
aslprep/workflows/asl/gecbf.py 14.65% <42.85%> (+1.01%) ⬆️
aslprep/tests/test_cli.py 77.33% <48.48%> (-22.67%) ⬇️
aslprep/workflows/asl/qc.py 54.38% <54.38%> (ø)
aslprep/interfaces/cbf_computation.py 68.78% <61.13%> (-3.18%) ⬇️
aslprep/workflows/asl/plotting.py 65.45% <65.45%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo merged commit 075038d into PennLINC:main Mar 30, 2023
9 checks passed
@tsalo tsalo deleted the use-correct-tr branch March 30, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RepetitionTime is used where RepetitionTimePreparation should be used
2 participants